netdev - Re: [PATCH net-next] fib: remove unnecessary input parameters in fib_default_rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92bde58c-eea8-400a-9773-b364208a7326@kernel.org>
Date: Tue, 2 Jan 2024 08:53:11 -0700
From: David Ahern <dsahern@...nel.org>
To: Zhengchao Shao <shaozhengchao@...wei.com>, netdev@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net-next] fib: remove unnecessary input parameters in
 fib_default_rule_add

On 1/2/24 12:15 AM, Zhengchao Shao wrote:
> When fib_default_rule_add is invoked, the value of the input parameter
> 'flags' is always 0. Rules uses kzalloc to allocate memory, so 'flags' has
> been initialized to 0. Therefore, remove the input parameter 'flags' in
> fib_default_rule_add.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  include/net/fib_rules.h | 3 +--
>  net/core/fib_rules.c    | 3 +--
>  net/ipv4/fib_rules.c    | 6 +++---
>  net/ipv4/ipmr.c         | 2 +-
>  net/ipv6/fib6_rules.c   | 4 ++--
>  net/ipv6/ip6mr.c        | 2 +-
>  6 files changed, 9 insertions(+), 11 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>