[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <17a2c694-2c48-46dc-b028-68793a31a984@gmail.com>
Date: Tue, 2 Jan 2024 12:29:58 -0700
From: David Ahern <dsahern@...il.com>
To: Leon Romanovsky <leon@...nel.org>,
Stephen Hemminger <stephen@...workplumber.org>
Cc: Chengchang Tang <tangchengchang@...wei.com>,
Junxian Huang <huangjunxian6@...ilicon.com>, jgg@...pe.ca,
netdev@...r.kernel.org, linux-rdma@...r.kernel.org, linuxarm@...wei.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH iproute2-rc 1/2] rdma: Fix core dump when pretty is used
On 1/2/24 12:17 PM, Leon Romanovsky wrote:
>>
>> Part of the problem is the meaning of pretty mode is different in rdma
>> than all of the other commands. The meaning of the flags should be the
>> same across ip, devlink, tc, and rdma; therefore pretty should mean
>> nothing unless json is enabled.
>
> I was very inspired by devlink when wrote rdmatool. It is supposed to
> behave the same. :)
You need better inspirations :-)
It was a mistake to merge devlink source code into iproute2 without a
commitment to bring it inline with other iproute2 commands.
Powered by blists - more mailing lists