[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZZPoKceXELZQU8cq@shell.armlinux.org.uk>
Date: Tue, 2 Jan 2024 10:40:41 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Yanteng Si <siyanteng@...ngson.cn>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com,
fancer.lancer@...il.com, Jose.Abreu@...opsys.com,
chenhuacai@...ngson.cn, guyinggang@...ngson.cn,
netdev@...r.kernel.org, chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v7 3/9] net: stmmac: dwmac-loongson: Add full
PCI support
On Tue, Dec 19, 2023 at 10:17:06PM +0800, Yanteng Si wrote:
> @@ -125,42 +126,48 @@ static int loongson_dwmac_probe(struct pci_dev *pdev,
> if (ret)
> goto err_disable_device;
>
> - bus_id = of_alias_get_id(np, "ethernet");
> - if (bus_id >= 0)
> - plat->bus_id = bus_id;
> + if (np) {
> + bus_id = of_alias_get_id(np, "ethernet");
> + if (bus_id >= 0)
> + plat->bus_id = bus_id;
>
> - phy_mode = device_get_phy_mode(&pdev->dev);
> - if (phy_mode < 0) {
> - dev_err(&pdev->dev, "phy_mode not found\n");
> - ret = phy_mode;
> - goto err_disable_device;
> + phy_mode = device_get_phy_mode(&pdev->dev);
> + if (phy_mode < 0) {
> + dev_err(&pdev->dev, "phy_mode not found\n");
> + ret = phy_mode;
> + goto err_disable_device;
> + }
> + plat->phy_interface = phy_mode;
> }
>
> - plat->phy_interface = phy_mode;
> -
So this is why phy_interface changes in patch 2. It would have been good
to make a forward reference to this change to explain in patch 2 why the
"default" value has been set there. Or maybe move the setting of that
default value into this patch?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists