netdev - Re: [PATCH net-next 2/2] net: ethtool: add a NO_CHANGE uAPI for new RXFH's input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240102160526.6178fd04@kernel.org>
Date: Tue, 2 Jan 2024 16:05:26 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ahmed Zaki <ahmed.zaki@...el.com>
Cc: netdev@...r.kernel.org, corbet@....net, jesse.brandeburg@...el.com,
 anthony.l.nguyen@...el.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, vladimir.oltean@....com, andrew@...n.ch,
 horms@...nel.org, mkubecek@...e.cz, willemdebruijn.kernel@...il.com,
 gal@...dia.com, alexander.duyck@...il.com, ecree.xilinx@...il.com, Jacob
 Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net-next 2/2] net: ethtool: add a NO_CHANGE uAPI for new
 RXFH's input_xfrm

On Thu, 21 Dec 2023 11:42:35 -0700 Ahmed Zaki wrote:
> +	     rxfh.key_size == 0 && rxfh.hfunc == ETH_RSS_HASH_NO_CHANGE &&
> +	     rxfh.input_xfrm == RXH_XFRM_NO_CHANGE))

This looks fine, but we also need a check to make sure input_xfrm
doesn't have bits other than RXH_XFRM_SYM_XOR set, right?