netdev - Re: [PATCH] ice: fix building withouto XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c66dd905-3342-44ff-9aa7-ff2c7b9024c7@app.fastmail.com>
Date: Wed, 03 Jan 2024 12:19:50 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Maciej Fijalkowski" <maciej.fijalkowski@...el.com>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: "Jesse Brandeburg" <jesse.brandeburg@...el.com>,
 "Anthony L Nguyen" <anthony.l.nguyen@...el.com>,
 "Jakub Kicinski" <kuba@...nel.org>, "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>,
 "Simon Horman" <horms@...nel.org>, "Daniel Borkmann" <daniel@...earbox.net>,
 "Larysa Zaremba" <larysa.zaremba@...el.com>,
 "Piotr Raczynski" <piotr.raczynski@...el.com>,
 "Amritha Nambiar" <amritha.nambiar@...el.com>,
 "Alexei Starovoitov" <ast@...nel.org>,
 "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
 Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ice: fix building withouto XDP

On Wed, Jan 3, 2024, at 11:54, Maciej Fijalkowski wrote:
> On Wed, Jan 03, 2024 at 11:24:45AM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The newly added function fails to build when struct xsk_cb_desc is
>> not defined:
>> 
>> drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb':
>> drivers/net/ethernet/intel/ice/ice_base.c:525:16: error: variable 'desc' has initializer but incomplete type
>> 
>> Hide this part in the same #ifdef that controls the structure definition.
>
> Hey Arnd,
>
> this has been fixed by Vladimir:
> https://lore.kernel.org/netdev/20231219110205.1289506-1-vladimir.oltean@nxp.com/
>
> in a way that we don't have to wrap driver code with ifdefs.

Ok, sounds good.

    Arnd