netdev - Re: [PATCH 0/2] net/smc: Adjustments for two function implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41536899-3ca2-4413-b483-3d27ffe0d7f4@linux.ibm.com>
Date: Wed, 3 Jan 2024 14:44:49 +0100
From: Wenjia Zhang <wenjia@...ux.ibm.com>
To: Markus Elfring <Markus.Elfring@....de>, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        "D. Wythe"
 <alibuda@...ux.alibaba.com>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Jan Karcher <jaka@...ux.ibm.com>, Paolo Abeni <pabeni@...hat.com>,
        Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>
Subject: Re: [PATCH 0/2] net/smc: Adjustments for two function implementations

On 31.12.23 15:55, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 31 Dec 2023 15:48:45 +0100
> 
> A few update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (2):
>    Return directly after a failed kzalloc() in smc_fill_gid_list()
>    Improve exception handling in smc_llc_cli_add_link_invite()
> 
>   net/smc/af_smc.c  |  2 +-
>   net/smc/smc_llc.c | 15 +++++++--------
>   2 files changed, 8 insertions(+), 9 deletions(-)
> 
> --
> 2.43.0
> 

Hi Markus,

Thank you for trying to improve our code!
However, I'm on the same page with Wen Gu. I could not see the necessity 
of the patches.
BTW, if you want to send fix patches, please provide the error messages 
you met, the procedure of reproducing the issue and the correspoinding 
commit messages. If you want to send feature patches, I'd like to see a 
well thought-out patch or patch series. E.g. In our component, the 
kfree(NULL) issue doesn't only occur in the positions where you 
mentioned in the patch series, also somewhere else. I would be grateful 
if all of them would be cleaned up, not just some pieces.

Thanks,
Wenjia