netdev - Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Add LED infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f9b8a8f-6741-4676-900a-e5832eb31fba@lunn.ch>
Date: Wed, 3 Jan 2024 15:09:23 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Tobias Waldekranz <tobias@...dekranz.com>
Cc: davem@...emloft.net, kuba@...nel.org, f.fainelli@...il.com,
	olteanv@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Add LED infrastructure

On Wed, Jan 03, 2024 at 11:33:50AM +0100, Tobias Waldekranz wrote:
> Parse LEDs from DT and register them with the kernel, for chips that
> support it. No actual implementations exist yet, they will be added in
> upcoming commits.

Hi Tobias

There are three of us now working on this. Linus, you and me. We all
have different implementations.

What i don't like about this is that is has code which is going to be
repeated in all DSA drivers, and even in all MAC drivers. I've already
posted one patch series which added generic DSA support for LEDs, and
some basic mv88e6xxx code. It got NACKed by Vladimir. So i'm slowly
working on making it more generic, so it can be used by any MAC
driver.

I will try to post it in the next couple of days.

    Andrew

---
pw-bot: cr