netdev - Re: [PATCH net v2 1/2] rtnetlink: allow to set iface down before enslaving it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37a6dd80-6914-4865-967a-9dfa90f1adea@kernel.org>
Date: Wed, 3 Jan 2024 08:38:29 -0700
From: David Ahern <dsahern@...nel.org>
To: Nicolas Dichtel <nicolas.dichtel@...nd.com>,
 "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 Phil Sutter <phil@....cc>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] rtnetlink: allow to set iface down before
 enslaving it

On 1/3/24 2:48 AM, Nicolas Dichtel wrote:
> The below commit adds support for:
>> ip link set dummy0 down
>> ip link set dummy0 master bond0 up
> 
> but breaks the opposite:
>> ip link set dummy0 up
>> ip link set dummy0 master bond0 down
> 
> Let's add a workaround to have both commands working.
> 
> Cc: stable@...r.kernel.org
> Fixes: a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Acked-by: Phil Sutter <phil@....cc>
> ---
>  net/core/rtnetlink.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>