[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0cc0cfc3-14d3-43d9-8fa8-b2b76b1ca14e@6wind.com>
Date: Wed, 3 Jan 2024 17:17:13 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: David Ahern <dsahern@...nel.org>, "David S . Miller"
<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
Phil Sutter <phil@....cc>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net v2 2/2] selftests: rtnetlink: check enslaving iface in
a bond
Le 03/01/2024 à 16:42, David Ahern a écrit :
> On 1/3/24 2:48 AM, Nicolas Dichtel wrote:
>> @@ -1239,6 +1240,44 @@ kci_test_address_proto()
>> return $ret
>> }
>>
>> +kci_test_enslave_bonding()
>> +{
>> + local testns="testns"
>> + local bond="bond123"
>> + local dummy="dummy123"
>> + local ret=0
>> +
>> + run_cmd ip netns add "$testns"
>> + if [ $? -ne 0 ]; then
>> + end_test "SKIP bonding tests: cannot add net namespace $testns"
>> + return $ksft_skip
>> + fi
>> +
>> + # test native tunnel
>> + run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr
>> + run_cmd ip -netns $testns link add dev $dummy type dummy
>> + run_cmd ip -netns $testns link set dev $dummy up
>> + run_cmd ip -netns $testns link set dev $dummy master $bond down
>> + if [ $ret -ne 0 ]; then
>> + end_test "FAIL: enslave an up interface in a bonding"
>
> interface is up, being put as a port on a bond and taken down at the
> same time. That does not match this error message.
The idea was "the command used to enslave an up interface fails".
What about: "FAIL: set down and enslave an up interface in a bonding"
>
>
> Thanks for adding test cases. Besides the error message:
>
> Reviewed-by: David Ahern <dsahern@...nel.org
Thank you,
Nicolas
Powered by blists - more mailing lists