netdev - Re: [PATCH] bnxt: fix building without CONFIG_RFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLikiU6WC3EfPaNBrPsf3wAQU=8XbabA2nhVUUOBihQ29FA@mail.gmail.com>
Date: Wed, 3 Jan 2024 08:56:51 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Andy Gospodarek <andrew.gospodarek@...adcom.com>, Arnd Bergmann <arnd@...nel.org>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Pavan Chebbi <pavan.chebbi@...adcom.com>, Somnath Kotur <somnath.kotur@...adcom.com>, 
	Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, 
	Randy Schacher <stuart.schacher@...adcom.com>, 
	Vasundhara Volam <vasundhara-v.volam@...adcom.com>, Netdev <netdev@...r.kernel.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnxt: fix building without CONFIG_RFS_ACCEL

On Wed, Jan 3, 2024 at 8:01 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Wed, Jan 3, 2024, at 16:46, Andy Gospodarek wrote:
> > There is a good oppportunity to clean this up a little better.  When
> > CONFIG_RFS_ACCEL is not set there is no reason to even have
> > bnxt_cfg_ntp_filters included in the driver build.
> >
> > I'll talk to Michael and we will post a fix for this.
>
> Ok, thanks!

Yes, we can clean this up better.  User configured ntuple filters are
directly added and don't go through bnxt_cfg_ntp_filters() by way of
the workqueue.  I'll post the fix later today.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)