netdev - Re: [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240103133735.7bd660b9@kernel.org>
Date: Wed, 3 Jan 2024 13:37:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sergey Shtylyov <s.shtylyov@....ru>
Cc: <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH net] MAINTAINERS: I don't want to review Renesas
 Ethernet Switch driver

On Wed, 3 Jan 2024 23:56:15 +0300 Sergey Shtylyov wrote:
> I don't know this hardware, I don't have the manuals for it, so I can't
> provide a good review.  Let's exclude the Ethernet Switch related files.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>

> Index: net/MAINTAINERS
> ===================================================================
> --- net.orig/MAINTAINERS
> +++ net/MAINTAINERS
> @@ -18358,6 +18358,9 @@ L:	linux-renesas-soc@...r.kernel.org
>  F:	Documentation/devicetree/bindings/net/renesas,*.yaml
>  F:	drivers/net/ethernet/renesas/
>  F:	include/linux/sh_eth.h
> +X:	Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml
> +X:	drivers/net/ethernet/renesas/rcar_gen4_ptp.*
> +X:	drivers/net/ethernet/renesas/rswitch.*

First off, very nice to see a refinement of MAINTAINERS to narrow
down the scope and make it more precise. Thanks for doing that.

The solution itself is not very idiomatic, however :(
IIUC you want to support SuperH and the AVB implementation.
It'd be more usual to make the entry cover only the relevant files.
And for bonus points perhaps add an entry covering the switch files,
mark that entry as Orphan?