[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZZbJndeZ09-DeztP@nanopsycho>
Date: Thu, 4 Jan 2024 16:07:09 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
Cc: netdev@...r.kernel.org, vadim.fedorenko@...ux.dev,
michal.michalik@...el.com, milena.olech@...el.com,
pabeni@...hat.com, kuba@...nel.org, Jan Glaza <jan.glaza@...el.com>
Subject: Re: [PATCH net v2 4/4] dpll: hide "zombie" pins for userspace
Thu, Jan 04, 2024 at 12:11:32PM CET, arkadiusz.kubalewski@...el.com wrote:
[...]
>@@ -1179,6 +1195,10 @@ int dpll_nl_pin_set_doit(struct sk_buff *skb, struct genl_info *info)
What about dpll_nl_pin_get_doit(), dpll_nl_pin_id_get_doit()?
I think it would be better to move the check to:
dpll_pin_pre_doit()
> {
> struct dpll_pin *pin = info->user_ptr[0];
>
>+ if (!xa_empty(&pin->parent_refs) &&
>+ !dpll_pin_parents_registered(pin))
>+ return -ENODEV;
>+
> return dpll_pin_set_from_nlattr(pin, info);
> }
>
>--
>2.38.1
>
Powered by blists - more mailing lists