netdev - Re: [PATCH net-next 07/10] net: dsa: qca8k: consolidate calls to a single devm_of_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bx6tn3oovvtp6j6chpsxithjastispxayk5jcyajiueentduq@j25urork4n7w>
Date: Thu, 4 Jan 2024 15:49:24 +0000
From: Alvin Šipraga <ALSI@...g-olufsen.dk>
To: Vladimir Oltean <vladimir.oltean@....com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn
	<andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Luiz Angelo Daros
 de Luca <luizluca@...il.com>, Linus Walleij <linus.walleij@...aro.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>, Hauke Mehrtens
	<hauke@...ke-m.de>, Christian Marangi <ansuelsmth@...il.com>,
	Arınç ÜNAL <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 07/10] net: dsa: qca8k: consolidate calls to a
 single devm_of_mdiobus_register()

On Thu, Jan 04, 2024 at 04:00:34PM +0200, Vladimir Oltean wrote:
> __of_mdiobus_register() already calls __mdiobus_register() if the
> OF node provided as argument is NULL. We can take advantage of that
> and simplify the 2 code path, calling devm_of_mdiobus_register() only
> once for both cases.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Much neater!

Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

> ---
>  drivers/net/dsa/qca/qca8k-8xxx.c | 24 +++++++++++-------------
>  1 file changed, 11 insertions(+), 13 deletions(-)