netdev - Re: ethtool ioctl ABI: preferred way to expand uapi structure ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240104171732.5a3219b1@device-28.home>
Date: Thu, 4 Jan 2024 17:17:32 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Marek Behún <kabel@...nel.org>
Cc: Michal Kubecek <mkubecek@...e.cz>, netdev@...r.kernel.org, Andrew Lunn
 <andrew@...n.ch>, Russell King <linux@...linux.org.uk>, Heiner Kallweit
 <hkallweit1@...il.com>
Subject: Re: ethtool ioctl ABI: preferred way to expand uapi structure
 ethtool_eee for additional link modes?

Hello Marek,

On Thu, 4 Jan 2024 16:14:16 +0100
Marek Behún <kabel@...nel.org> wrote:

> Hello,
> 
> the legacy ioctls ETHTOOL_GSET and ETHTOOL_SSET, which pass structure
> ethtool_cmd, were superseded by ETHTOOL_GLINKSETTINGS and
> ETHTOOL_SLINKSETTINGS.
> 
> This was done because the original structure only contains 32-bit words
> for supported, advertising and lp_advertising link modes. The new
> structure ethtool_link_settings contains member
>   s8 link_mode_masks_nwords;
> and a flexible array
>   __u32 link_mode_masks[];
> in order to overcome this issue.
> 
> But currently we still have only legacy structure ethtool_eee for EEE
> settings:
>   struct ethtool_eee {
>     __u32 cmd;
>     __u32 supported;
>     __u32 advertised;
>     __u32 lp_advertised;
>     __u32 eee_active;
>     __u32 eee_enabled;
>     __u32 tx_lpi_enabled;
>     __u32 tx_lpi_timer;
>     __u32 reserved[2];
>   };
> 
> Thus ethtool is unable to get/set EEE configuration for example for
> 2500base-T and 5000base-T link modes, which are now available in
> several PHY drivers.

If I am not mistake, I think this series from Heiner tries to address
exactly that :
https://lore.kernel.org/netdev/783d4a61-2f08-41fc-b91d-bd5f512586a2@gmail.com/

Thanks,

Maxime