netdev - Re: [PATCH net-next 04/10] net: dsa: qca8k: put MDIO bus OF node on qca8k_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240104172014.pnbmvwjozul766pt@skbuf>
Date: Thu, 4 Jan 2024 19:20:14 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Luiz Angelo Daros de Luca <luizluca@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Christian Marangi <ansuelsmth@...il.com>,
	Arınç ÜNAL <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 04/10] net: dsa: qca8k: put MDIO bus OF node on
 qca8k_mdio_register() failure

On Thu, Jan 04, 2024 at 03:46:03PM +0000, Alvin Šipraga wrote:
> Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

Thanks for the review, Alvin.

> > ---
> >  drivers/net/dsa/qca/qca8k-8xxx.c | 21 ++++++++++++++++-----
> >  1 file changed, 16 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
> > index ec57d9d52072..5f47a290bd6e 100644
> > --- a/drivers/net/dsa/qca/qca8k-8xxx.c
> > +++ b/drivers/net/dsa/qca/qca8k-8xxx.c
> > @@ -949,10 +949,15 @@ qca8k_mdio_register(struct qca8k_priv *priv)
> >  	struct dsa_switch *ds = priv->ds;
> >  	struct device_node *mdio;
> >  	struct mii_bus *bus;
> > +	int err;
> 
> nit: besides qca8k_setup_mdio_bus(), the rest of the driver uses 'int ret'

Yeah, good point. It wasn't on my mind as one of the things to check.
If this is the only change that ends up being requested, I would prefer
dealing with it separately at once in both places, rather than resending
a series of 10 patches plus another one to also fix up qca8k_setup_mdio_bus().