netdev - Re: [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7273be70-64b8-3af1-85e2-4d7eb67fc4f1@omp.ru>
Date: Thu, 4 Jan 2024 23:23:50 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet
 Switch driver

On 1/4/24 12:37 AM, Jakub Kicinski wrote:

[...]
>> I don't know this hardware, I don't have the manuals for it, so I can't
>> provide a good review.  Let's exclude the Ethernet Switch related files.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
>> Index: net/MAINTAINERS
>> ===================================================================
>> --- net.orig/MAINTAINERS
>> +++ net/MAINTAINERS
>> @@ -18358,6 +18358,9 @@ L:	linux-renesas-soc@...r.kernel.org
>>  F:	Documentation/devicetree/bindings/net/renesas,*.yaml
>>  F:	drivers/net/ethernet/renesas/
>>  F:	include/linux/sh_eth.h
>> +X:	Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml
>> +X:	drivers/net/ethernet/renesas/rcar_gen4_ptp.*
>> +X:	drivers/net/ethernet/renesas/rswitch.*
> 
> First off, very nice to see a refinement of MAINTAINERS to narrow
> down the scope and make it more precise. Thanks for doing that.

   It's long overdue. I've got a lot of the rswitch patches in my inbox
which I mostly ignored. Unfortunately, I've been loaded with fixing the
Svace (static analyzer) reports for about 2 years now...

> The solution itself is not very idiomatic, however :(
> IIUC you want to support SuperH and the AVB implementation.
> It'd be more usual to make the entry cover only the relevant files.

   Yeah, figured that out fianally... but still not sure what should
I do with Kconfig and Makefile...

> And for bonus points perhaps add an entry covering the switch files,
> mark that entry as Orphan?

   Will try to loop in Shimoda-san first -- maybe he'd be brave enough
to step in... :-)

MBR, Sergey