netdev - Re: [PATCH v3] selinux: Fix error priority for bind with AF_UNSPEC on PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhSkg6=Y5OgUmdkBA2MBrkQT3idZ7NWG2msqdsFZL03TyA@mail.gmail.com>
Date: Thu, 4 Jan 2024 16:57:11 -0500
From: Paul Moore <paul@...l-moore.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Mickaël Salaün <mic@...ikod.net>, 
	Eric Paris <eparis@...isplace.org>, Stephen Smalley <stephen.smalley.work@...il.com>, 
	Günther Noack <gnoack@...gle.com>, 
	Konstantin Meskhidze <konstantin.meskhidze@...wei.com>, linux-security-module@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v3] selinux: Fix error priority for bind with AF_UNSPEC on
 PF_INET6 socket

On Thu, Jan 4, 2024 at 6:40 AM Muhammad Usama Anjum
<usama.anjum@...labora.com> wrote:
>
> On 1/3/24 9:34 PM, Mickaël Salaün wrote:
> > The IPv6 network stack first checks the sockaddr length (-EINVAL error)
> > before checking the family (-EAFNOSUPPORT error).
> >
> > This was discovered thanks to commit a549d055a22e ("selftests/landlock:
> > Add network tests").
> >
> > Cc: Eric Paris <eparis@...isplace.org>
> > Cc: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
> > Cc: Paul Moore <paul@...l-moore.com>
> > Cc: Stephen Smalley <stephen.smalley.work@...il.com>
> > Reported-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> > Closes: https://lore.kernel.org/r/0584f91c-537c-4188-9e4f-04f192565667@collabora.com
> > Fixes: 0f8db8cc73df ("selinux: add AF_UNSPEC and INADDR_ANY checks to selinux_socket_bind()")
> > Signed-off-by: Mickaël Salaün <mic@...ikod.net>
> Thank you Mickaël for the patch. Tested patch on v6.7-rc8.
>
> Tested-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

This looks good to me, and since it is rather trivial I'm going to go
ahead and merge this into selinux/next so it should go up to Linus
during the upcoming merge window.

Thanks everyone!

-- 
paul-moore.com