netdev - Re: [PATCH net-next v5 00/13] Introduce PHY listing and link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240104154721.192694a8@kernel.org>
Date: Thu, 4 Jan 2024 15:47:21 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>,
 patchwork-bot+netdevbpf@...nel.org, davem@...emloft.net,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 thomas.petazzoni@...tlin.com, andrew@...n.ch, edumazet@...gle.com,
 pabeni@...hat.com, linux-arm-kernel@...ts.infradead.org,
 christophe.leroy@...roup.eu, herve.codina@...tlin.com,
 f.fainelli@...il.com, hkallweit1@...il.com, vladimir.oltean@....com,
 kory.maincent@...tlin.com, jesse.brandeburg@...el.com, corbet@....net,
 kabel@...nel.org, piergiorgio.beruto@...il.com, o.rempel@...gutronix.de,
 nicveronese@...il.com, horms@...nel.org
Subject: Re: [PATCH net-next v5 00/13] Introduce PHY listing and
 link_topology tracking

On Wed, 3 Jan 2024 15:33:36 +0100 Maxime Chevallier wrote:
> I think this could help in reviewing the overall design and identifying
> any glaring issue with this.

The netlink handling looks a bit wobbly to me.
I commented best I could in the 20min I had to look at this code :(
I think it'd be best to revert, if you don't mind, because reviewing
incremental fixes will get even harder.