netdev - Re: [PATCH v2 net-next 07/11] net: ena: Refactor napi functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240103180035.1fc5e68a@kernel.org>
Date: Wed, 3 Jan 2024 18:00:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
 "Woodhouse, David" <dwmw@...zon.com>, "Machulsky, Zorik"
 <zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, Saeed
 Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, "Liguori,
 Anthony" <aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>,
 "Belgazal, Netanel" <netanel@...zon.com>, "Saidi, Ali"
 <alisaidi@...zon.com>, "Herrenschmidt, Benjamin" <benh@...zon.com>,
 "Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam"
 <ndagan@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, "Itzko, Shahar"
 <itzko@...zon.com>, "Abboud, Osama" <osamaabb@...zon.com>, "Ostrovsky,
 Evgeny" <evostrov@...zon.com>, "Tabachnik, Ofir" <ofirt@...zon.com>
Subject: Re: [PATCH v2 net-next 07/11] net: ena: Refactor napi functions

On Mon, 1 Jan 2024 19:08:51 +0000 darinzon@...zon.com wrote:
> -	xdp_work_done = ena_clean_xdp_irq(tx_ring, xdp_budget);
> +	work_done = ena_clean_xdp_irq(tx_ring, budget);

Not related to this series, but please make sure that if budget is
0 you do *no* XDP processing, Rx or Tx. XDP expects to run in softirq
context, when budget is 0 we may be in hard IRQ.