netdev - Re: [PATCH net-next] net: ethtool: Fix set RXNFC call on drivers with no RXFH support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d00793e5-2895-4ce3-8da6-d99bedbed6ba@nvidia.com>
Date: Thu, 4 Jan 2024 08:51:59 +0200
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Ahmed Zaki <ahmed.zaki@...el.com>
Subject: Re: [PATCH net-next] net: ethtool: Fix set RXNFC call on drivers with
 no RXFH support

On 03/01/2024 23:39, Jakub Kicinski wrote:
> On Wed, 3 Jan 2024 21:16:20 +0200 Gal Pressman wrote:
>> Some interfaces support get/set_rxnfc but not get/set_rxfh (mlx5 IPoIB
>> for example).
>> Instead of failing the RXNFC command, do the symmetric xor sanity check
>> for interfaces that support get_rxfh only.
>>
>> Fixes: dcd8dbf9e734 ("net: ethtool: get rid of get/set_rxfh_context functions")
>> Cc: Ahmed Zaki <ahmed.zaki@...el.com>
>> Signed-off-by: Gal Pressman <gal@...dia.com>
> 
> Thanks, we got a similar patch from Gerhard, applied yesterday:
> 501869fecfbc ("net: ethtool: Fix symmetric-xor RSS RX flow hash check")

Thanks, slipped under my radar, nice to see that we fixed it the same way.