netdev - Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: Convert ret val type from s32 to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bfd7069-8222-4388-bc1f-d4e77093b503@molgen.mpg.de>
Date: Thu, 4 Jan 2024 08:26:16 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Cc: Jacob Keller <jacob.e.keller@...el.com>,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 anthony.l.nguyen@...el.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: Convert ret val type
 from s32 to int

[Re-sent with diff removed, so message size limit of 90 kB of list 
Intel-wired-lan is met.]

Dear Jedrzej,


Thank you for your patch.

Am 03.01.24 um 11:11 schrieb Jedrzej Jagielski:
> Currently big amount of the functions returning standard
> error codes are of type s32. Convert them to regular
> ints.

Please make use of the full allowed text width of 75 characters per line.

Also please add the motivation. Why are regular ints better?

[…]


Kind regards,

Paul