netdev - RE: [PATCH net v2 2/2] net: phylink: Add module_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW6PR11MB8310E51E5EEDA8EE98BC37D4B967A@MW6PR11MB8310.namprd11.prod.outlook.com>
Date: Thu, 4 Jan 2024 09:45:47 +0000
From: "Gan, Yi Fang" <yi.fang.gan@...el.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andrew Halaney
	<ahalaney@...hat.com>, Javier Martinez Canillas <javierm@...hat.com>, "John
 Stultz" <jstultz@...gle.com>, "Rafael J . Wysocki" <rafael@...nel.org>, "Jens
 Axboe" <axboe@...nel.dk>, Russell King <linux@...linux.org.uk>, "Heiner
 Kallweit" <hkallweit1@...il.com>, "David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Marek Behún
	<kabel@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Looi, Hong Aun" <hong.aun.looi@...el.com>,
	"Voon, Weifeng" <weifeng.voon@...el.com>, "Song, Yoong Siang"
	<yoong.siang.song@...el.com>, "Lai, Peter Jun Ann"
	<peter.jun.ann.lai@...el.com>, "Choong, Yong Liang"
	<yong.liang.choong@...el.com>
Subject: RE: [PATCH net v2 2/2] net: phylink: Add module_exit_stub()

Hi Andrew,

The function phylink_init() is introduced by others.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.6.y&id=eca68a3c7d05b38b4e728cead0c49718f2bc1d5a 
The module_exit() is added by referring to
https://elixir.bootlin.com/linux/latest/source/kernel/module/main.c#L738.
Since the macro function is rejected, I will send a V3.
Let's see if Rusell King has any comment. Thanks.


Best Regards,
Gan Yi Fang

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Thursday, December 21, 2023 5:23 PM
> To: Gan, Yi Fang <yi.fang.gan@...el.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Andrew Halaney
> <ahalaney@...hat.com>; Javier Martinez Canillas <javierm@...hat.com>; John
> Stultz <jstultz@...gle.com>; Rafael J . Wysocki <rafael@...nel.org>; Jens Axboe
> <axboe@...nel.dk>; Russell King <linux@...linux.org.uk>; Heiner Kallweit
> <hkallweit1@...il.com>; David S . Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Marek Behún <kabel@...nel.org>;
> netdev@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com; linux-
> arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Looi, Hong Aun
> <hong.aun.looi@...el.com>; Voon, Weifeng <weifeng.voon@...el.com>; Song,
> Yoong Siang <yoong.siang.song@...el.com>; Lai, Peter Jun Ann
> <peter.jun.ann.lai@...el.com>; Choong, Yong Liang
> <yong.liang.choong@...el.com>
> Subject: Re: [PATCH net v2 2/2] net: phylink: Add module_exit_stub()
> 
> On Thu, Dec 21, 2023 at 04:51:09PM +0800, Gan, Yi Fang wrote:
> > In delete_module(), if mod->init callback is defined but mod->exit
> > callback is not defined, it will assume the module cannot be removed
> > and return EBUSY. The module_exit() is missing from current phylink
> > module drive causing failure while unloading it.
> 
> You are missing justification it is actually safe to remove phylink. Maybe Russell
> King deliberately did not implement
> module_exit() because it can explode in interesting ways if it was?
> 
> 	Andrew