netdev - Re: [PATCH net-next v2 1/8] octeon_ep_vf: Add driver framework and device initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240105105823.GT31813@kernel.org>
Date: Fri, 5 Jan 2024 10:58:23 +0000
From: Simon Horman <horms@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, hgani@...vell.com,
	vimleshk@...vell.com, sedara@...vell.com, egallen@...hat.com,
	mschmidt@...hat.com, pabeni@...hat.com, kuba@...nel.org,
	wizhao@...hat.com, kheib@...hat.com, konguyen@...hat.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jonathan Corbet <corbet@....net>,
	Veerasenareddy Burru <vburru@...vell.com>,
	Satananda Burla <sburla@...vell.com>,
	Shannon Nelson <shannon.nelson@....com>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	Alan Brady <alan.brady@...el.com>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Brett Creeley <brett.creeley@....com>,
	Joshua Hay <joshua.a.hay@...el.com>, Andrew Lunn <andrew@...n.ch>,
	Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net-next v2 1/8] octeon_ep_vf: Add driver framework and
 device initialization

On Sat, Dec 23, 2023 at 05:39:53AM -0800, Shinas Rasheed wrote:
> Add driver framework and device setup and initialization for Octeon
> PCI Endpoint NIC VF.
> 
> Add implementation to load module, initialize, register network device,
> cleanup and unload module.
> 
> Signed-off-by: Shinas Rasheed <srasheed@...vell.com>

Hi Shinas,

a minor nit from my side.

...

> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h

...

> +#ifndef UINT64_MAX
> +#define UINT64_MAX		((u64)(~((u64)0)))        /* 0xFFFFFFFFFFFFFFFF */
> +#endif

nit: UINT64_MAX appears to be unused, so I think it can be removed.
     Else, perhaps the code can be updated to use U64_MAX instead.

...