netdev - RE: [PATCH v3 1/3] mlxbf_gige: Fix kernel panic at shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR12MB7282BB0D130E7A1E80B72ABBD7662@PH7PR12MB7282.namprd12.prod.outlook.com>
Date: Fri, 5 Jan 2024 16:05:46 +0000
From: Asmaa Mnebhi <asmaa@...dia.com>
To: Florian Fainelli <f.fainelli@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"olteanv@...il.com" <olteanv@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, David Thompson
	<davthompson@...dia.com>
Subject: RE: [PATCH v3 1/3] mlxbf_gige: Fix kernel panic at shutdown

> > >   	priv = container_of(napi, struct mlxbf_gige, napi);
> > >
> > > +	if (!priv)
> > > +		return 0;
> >
> > Do you still need this test even after you unregistered the network
> > device in your shutdown routine?
> 
> always good to check variables but if want me to remove it I can.

I will resubmit this patch with addressed comments after our QA has done more thorough testing. 

Thank you.
Asmaa