netdev - Re: [PATCH net-next v3 7/8] octeon_ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240105193251.028e8eb5@kernel.org>
Date: Fri, 5 Jan 2024 19:32:51 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <hgani@...vell.com>, <vimleshk@...vell.com>, <sedara@...vell.com>,
 <egallen@...hat.com>, <mschmidt@...hat.com>, <pabeni@...hat.com>,
 <horms@...nel.org>, <wizhao@...hat.com>, <kheib@...hat.com>,
 <konguyen@...hat.com>, Veerasenareddy Burru <vburru@...vell.com>, Satananda
 Burla <sburla@...vell.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool support

On Fri, 5 Jan 2024 12:38:22 -0800 Shinas Rasheed wrote:
> +	"rx_dropped",
> +	"tx_dropped",

Please take a close look at rtnl_link_stats64.
Anything that fits should really go to standard interface stats.
This will benefit the piles of monitoring SW which gather standard
stats.

> +	"rx_dropped_pkts_fifo_full",

This one is probably rx_missed_errors