netdev - Re: [PATCH v2 RFC 3/5] ethtool: adjust struct ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 7 Jan 2024 17:40:39 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Russell King <rmk+kernel@...linux.org.uk>,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 RFC 3/5] ethtool: adjust struct ethtool_keee to kernel
 needs

On Sat, Jan 06, 2024 at 11:20:43PM +0100, Heiner Kallweit wrote:
> This patch changes the following in struct ethtool_keee
> - remove member cmd, it's not needed on kernel side

Ah, O.K. That invalidates most of my comments on the previous
patch. Please expand the commit message of the previous patch to say
that keee cmd will be removed in the next patch.

> - remove reserved fields
> - switch the semantically boolean members to type bool
> 
> We don't have to change any user of the boolean members due to the
> implicit casting from/to bool. A small change is needed where a
> pointer to bool members is used, in addition remove few now unneeded
> double negations.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew