netdev - Re: Kernel 6.7.0 intel i40e driver not build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbcc4c92-b4a2-27ad-ed6e-4064ee1020ba@intel.com>
Date: Mon, 8 Jan 2024 10:11:32 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Martin Zaharinov <micron10@...il.com>, netdev <netdev@...r.kernel.org>,
	<karen.ostrowska@...el.com>, <mateusz.palczewski@...el.com>,
	<wojciech.drewek@...el.com>, <przemyslaw.kitszel@...el.com>,
	<rafal.romanowski@...el.com>
Subject: Re: Kernel 6.7.0 intel i40e driver not build



On 1/8/2024 7:10 AM, Martin Zaharinov wrote:
> Hi all
> 
> this is fix for problem in one of commit is remove i40e_type.h from i40e_diag.h please commit fix:
> 
> --- linux-6.7.0/drivers/net/ethernet/intel/i40e/i40e_diag.h.orig	2024-01-08 15:08:35.903036237 +0000
> +++ linux-6.7.0/drivers/net/ethernet/intel/i40e/i40e_diag.h	2024-01-08 15:08:50.107313186 +0000
> @@ -4,6 +4,7 @@
>   #ifndef _I40E_DIAG_H_
>   #define _I40E_DIAG_H_
> 
> +#include "i40e_type.h"
>   #include "i40e_adminq_cmd.h"
> 
>   /* forward-declare the HW struct for the compiler */

Hi Martin,

Thanks for the report and proposed fix. I haven't come across this in 
any of our testing or a report from any of the build bots. I suspect the 
proper include is implicitly included or excluded somewhere outside the 
driver. Could you provide more info on your setup? arch and config file 
ideally. I'm guessing the config would be too big for the list so a link 
or direct email with it would be great.

Thanks,
Tony

>> On 8 Jan 2024, at 15:32, Martin Zaharinov <micron10@...il.com> wrote:
>>
>> Add more people from Intel .
>>
>> best regards,
>> m.
>>
>>> On 8 Jan 2024, at 15:30, Martin Zaharinov <micron10@...il.com> wrote:
>>>
>>> Hi Tony Nguyen ,
>>>
>>>
>>> Please check make error .
>>> This is build of latest kernel 6.7.0 :
>>>
>>>
>>>
>>> CALL    scripts/checksyscalls.sh
>>> CC [M]  drivers/net/ethernet/intel/i40e/i40e_ethtool.o
>>> CC [M]  drivers/net/ethernet/intel/i40e/i40e_diag.o
>>> In file included from drivers/net/ethernet/intel/i40e/i40e_diag.h:7,
>>>                 from drivers/net/ethernet/intel/i40e/i40e_diag.c:4:
>>> drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:33:9: error: unknown type name '__le16'
>>>   33 |         __le16 flags;
>>>      |         ^~~~~~