netdev - Re: [PATCH net] rxrpc: Fix use of Don't Fragment flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1577954.1704809777@warthog.procyon.org.uk>
Date: Tue, 09 Jan 2024 14:16:17 +0000
From: David Howells <dhowells@...hat.com>
To: Marc Dionne <marc.dionne@...istor.com>
Cc: dhowells@...hat.com, "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
    Paolo Abeni <pabeni@...hat.com>, linux-afs@...ts.infradead.org,
    netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix use of Don't Fragment flag

Marc Dionne <marc.dionne@...istor.com> wrote:

> > +{
> > +       if (set)
> > +               ip_sock_set_mtu_discover(local->socket->sk, IP_PMTUDISC_DONT);
> > +       else
> > +               ip_sock_set_mtu_discover(local->socket->sk, IP_PMTUDISC_DO);
> > +}
> 
> Shouldn't those be reversed - don't fragment should be IP_PMTUDISC_DO?

Meh.  Yes.

> Also, and this is probably already an issue with current code, I don't
> think this is effective if the socket is V6, which it will be in most
> cases.

Hmmm...  I guess I should tweak IPV6_MTU_DISCOVER also.

David