netdev - Re: [PATCH v3 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170476971804.2467890.1994452217560064962.robh@kernel.org>
Date: Mon, 8 Jan 2024 20:08:40 -0700
From: Rob Herring <robh@...nel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc: Paolo Abeni <pabeni@...hat.com>, Emil Renner Berthing <kernel@...il.dk>, devicetree@...r.kernel.org, Alexandre Torgue <alexandre.torgue@...s.st.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Giuseppe Cavallaro <peppe.cavallaro@...com>, linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, linux-stm32@...md-mailman.stormreply.com, Jose Abreu <joabreu@...opsys.com>, Conor Dooley <conor+dt@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Samin Guo <samin.guo@...rfivetech.com>, linux-arm-kernel@...ts.infradead.org, Jacob Keller <jacob.e.keller@...el.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, kernel@...labora.com
Subject: Re: [PATCH v3 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add
 JH7100 SoC compatible

On Fri, 22 Dec 2023 12:09:59 +0200, Cristian Ciocaltea wrote:
> The Synopsys DesignWare MAC found on StarFive JH7100 SoC is mostly
> similar to the newer JH7110, but it requires only two interrupts and a
> single reset line, which is 'ahb' instead of the commonly used
> 'stmmaceth'.
> 
> Since the common binding 'snps,dwmac' allows selecting 'ahb' only in
> conjunction with 'stmmaceth', extend the logic to also permit exclusive
> usage of the 'ahb' reset name.  This ensures the following use cases are
> supported:
> 
>   JH7110: reset-names = "stmmaceth", "ahb";
>   JH7100: reset-names = "ahb";
>   other:  reset-names = "stmmaceth";
> 
> Also note the need to use a different dwmac fallback, as v5.20 applies
> to JH7110 only, while JH7100 relies on v3.7x.
> 
> Additionally, drop the reset description items from top-level binding as
> they are already provided by the included snps,dwmac schema.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   | 11 +--
>  .../bindings/net/starfive,jh7110-dwmac.yaml   | 72 +++++++++++++------
>  2 files changed, 57 insertions(+), 26 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>