netdev - Re: [PATCH bpf-next v2 09/15] selftests/bpf: Test assigning ID to scalars on spill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bzb4Gy1CTE7ebjA6b2vtZ7dhZnpsw25YnGTx6y2rYYFmcw@mail.gmail.com>
Date: Tue, 9 Jan 2024 15:34:07 -0800
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Maxim Mikityanskiy <maxtram95@...il.com>
Cc: Eduard Zingerman <eddyz87@...il.com>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Shung-Hsi Yu <shung-hsi.yu@...e.com>, John Fastabend <john.fastabend@...il.com>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>, 
	Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, bpf@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	netdev@...r.kernel.org, Maxim Mikityanskiy <maxim@...valent.com>
Subject: Re: [PATCH bpf-next v2 09/15] selftests/bpf: Test assigning ID to
 scalars on spill

On Mon, Jan 8, 2024 at 12:53 PM Maxim Mikityanskiy <maxtram95@...il.com> wrote:
>
> From: Maxim Mikityanskiy <maxim@...valent.com>
>
> The previous commit implemented assigning IDs to registers holding
> scalars before spill. Add the test cases to check the new functionality.
>
> Signed-off-by: Maxim Mikityanskiy <maxim@...valent.com>
> Acked-by: Eduard Zingerman <eddyz87@...il.com>
> ---
>  .../selftests/bpf/progs/verifier_spill_fill.c | 133 ++++++++++++++++++
>  1 file changed, 133 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/progs/verifier_spill_fill.c b/tools/testing/selftests/bpf/progs/verifier_spill_fill.c
> index f303ac19cf41..b05aab925ee5 100644
> --- a/tools/testing/selftests/bpf/progs/verifier_spill_fill.c
> +++ b/tools/testing/selftests/bpf/progs/verifier_spill_fill.c
> @@ -766,4 +766,137 @@ l0_%=:    r0 = 0;                                         \
>         : __clobber_all);
>  }
>

[...]

> +
> +SEC("xdp")
> +__description("8-bit spill of 8-bit reg should assign ID")
> +__success __retval(0)
> +__naked void spill_8bit_of_8bit_ok(void)
> +{
> +       asm volatile ("                                 \
> +       /* Roll one bit to make the register inexact. */\
> +       call %[bpf_get_prandom_u32];                    \
> +       r0 &= 0x80;                                     \
> +       /* 8-bit spill r0 to stack - should assign an ID. */\
> +       *(u8*)(r10 - 8) = r0;                           \
> +       /* 8-bit fill r1 from stack - should preserve the ID. */\
> +       r1 = *(u8*)(r10 - 8);                           \
> +       /* Compare r1 with another register to trigger find_equal_scalars.\
> +        * Having one random bit is important here, otherwise the verifier cuts\
> +        * the corners.                                 \
> +        */                                             \
> +       r2 = 0;                                         \
> +       if r1 != r2 goto l0_%=;                         \
> +       /* The result of this comparison is predefined. */\
> +       if r0 == r2 goto l0_%=;                         \
> +       /* Dead branch: the verifier should prune it. Do an invalid memory\
> +        * access if the verifier follows it.           \
> +        */                                             \
> +       r0 = *(u64*)(r9 + 0);                           \
> +       exit;                                           \
> +l0_%=: r0 = 0;                                         \
> +       exit;                                           \
> +"      :
> +       : __imm(bpf_get_prandom_u32)
> +       : __clobber_all);
> +}
> +

Can you add a test where we spill register of one size and fill a
different size? And what should the behavior be? Should we or should
we not preserve linked IDs in such situation?

>  char _license[] SEC("license") = "GPL";
> --
> 2.43.0
>