[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<BJSPR01MB05951FFA70FEDDD2917C37749E6AA@BJSPR01MB0595.CHNPR01.prod.partner.outlook.cn>
Date: Tue, 9 Jan 2024 07:27:48 +0000
From: ChunHau Tan <chunhau.tan@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "David S . Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
<robh+dt@...nel.org>, Emil Renner Berthing <kernel@...il.dk>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Maxime Coquelin
<mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
Simon Horman <horms@...nel.org>, Bartosz Golaszewski
<bartosz.golaszewski@...aro.org>, Andrew Halaney <ahalaney@...hat.com>,
Jisheng Zhang <jszhang@...nel.org>, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, Russell King <rmk+kernel@...linux.org.uk>
CC: Leyfoon Tan <leyfoon.tan@...rfivetech.com>, JeeHeng Sia
<jeeheng.sia@...rfivetech.com>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-stm32@...md-mailman.stormreply.com"
<linux-stm32@...md-mailman.stormreply.com>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive
JH8100 support
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Monday, 8 January, 2024 4:28 PM
> To: ChunHau Tan <chunhau.tan@...rfivetech.com>; David S . Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Rob Herring
> <robh+dt@...nel.org>; Emil Renner Berthing <kernel@...il.dk>; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>;
> Conor Dooley <conor+dt@...nel.org>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; Alexandre Torgue
> <alexandre.torgue@...s.st.com>; Simon Horman <horms@...nel.org>;
> Bartosz Golaszewski <bartosz.golaszewski@...aro.org>; Andrew Halaney
> <ahalaney@...hat.com>; Jisheng Zhang <jszhang@...nel.org>; Uwe
> Kleine-König <u.kleine-koenig@...gutronix.de>; Russell King
> <rmk+kernel@...linux.org.uk>
> Cc: Leyfoon Tan <leyfoon.tan@...rfivetech.com>; JeeHeng Sia
> <jeeheng.sia@...rfivetech.com>; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-stm32@...md-mailman.stormreply.com;
> linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add
> StarFive JH8100 support
>
> On 08/01/2024 08:58, Tan Chun Hau wrote:
> > Add StarFive JH8100 dwmac support.
> > JH8100 dwmac has one reset signal instead of 2 resets as in JH7110.
> >
> > Signed-off-by: Tan Chun Hau <chunhau.tan@...rfivetech.com>
> > ---
> > .../bindings/net/starfive,jh7110-dwmac.yaml | 28 ++++++++++++-------
> > 1 file changed, 18 insertions(+), 10 deletions(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > index 5e7cfbbebce6..3d0447726902 100644
> > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > +++
> b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > @@ -17,6 +17,7 @@ select:
> > contains:
> > enum:
> > - starfive,jh7110-dwmac
> > + - starfive,jh8100-dwmac
>
> I have doubts that you tested it. Missing change to snps,dwmac.
Will fix in V2.
>
> > required:
> > - compatible
> >
> > @@ -25,6 +26,7 @@ properties:
> > items:
> > - enum:
> > - starfive,jh7110-dwmac
> > + - starfive,jh8100-dwmac
> > - const: snps,dwmac-5.20
> >
> > reg:
> > @@ -54,16 +56,6 @@ properties:
> > minItems: 3
> > maxItems: 3
> >
> > - resets:
> > - items:
> > - - description: MAC Reset signal.
> > - - description: AHB Reset signal.
> > -
> > - reset-names:
> > - items:
> > - - const: stmmaceth
> > - - const: ahb
> > -
> > starfive,tx-use-rgmii-clk:
> > description:
> > Tx clock is provided by external rgmii clock.
> > @@ -93,6 +85,22 @@ required:
> >
> > allOf:
> > - $ref: snps,dwmac.yaml#
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - starfive,jh7110-dwmac
> > + then:
> > + properties:
> > + resets:
> > + items:
> > + - description: MAC Reset signal.
> > + - description: AHB Reset signal.
> > + resets-names:
> > + items:
> > + - const: stmmaceth
> > + - const: ahb
>
> Missing else: narrowing your jh8100.
Will fix in V2.
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists