netdev - RE: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 9 Jan 2024 08:12:29 +0000
From: ChunHau Tan <chunhau.tan@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh+dt@...nel.org>, Emil Renner Berthing <kernel@...il.dk>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Simon Horman <horms@...nel.org>, Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>, Andrew Halaney <ahalaney@...hat.com>,
	Jisheng Zhang <jszhang@...nel.org>, Uwe Kleine-König
	<u.kleine-koenig@...gutronix.de>, Russell King <rmk+kernel@...linux.org.uk>
CC: Leyfoon Tan <leyfoon.tan@...rfivetech.com>, JeeHeng Sia
	<jeeheng.sia@...rfivetech.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Tuesday, 9 January, 2024 3:59 PM
> To: ChunHau Tan <chunhau.tan@...rfivetech.com>; David S . Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Rob Herring
> <robh+dt@...nel.org>; Emil Renner Berthing <kernel@...il.dk>; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>;
> Conor Dooley <conor+dt@...nel.org>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; Alexandre Torgue
> <alexandre.torgue@...s.st.com>; Simon Horman <horms@...nel.org>;
> Bartosz Golaszewski <bartosz.golaszewski@...aro.org>; Andrew Halaney
> <ahalaney@...hat.com>; Jisheng Zhang <jszhang@...nel.org>; Uwe
> Kleine-König <u.kleine-koenig@...gutronix.de>; Russell King
> <rmk+kernel@...linux.org.uk>
> Cc: Leyfoon Tan <leyfoon.tan@...rfivetech.com>; JeeHeng Sia
> <jeeheng.sia@...rfivetech.com>; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-stm32@...md-mailman.stormreply.com;
> linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support
> 
> On 09/01/2024 08:25, ChunHau Tan wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: Monday, 8 January, 2024 5:07 PM
> >> To: ChunHau Tan <chunhau.tan@...rfivetech.com>; David S . Miller
> >> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> >> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Rob
> >> Herring <robh+dt@...nel.org>; Emil Renner Berthing <kernel@...il.dk>;
> >> Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> >> <krzysztof.kozlowski+dt@...aro.org>;
> >> Conor Dooley <conor+dt@...nel.org>; Maxime Coquelin
> >> <mcoquelin.stm32@...il.com>; Alexandre Torgue
> >> <alexandre.torgue@...s.st.com>; Simon Horman <horms@...nel.org>;
> >> Bartosz Golaszewski <bartosz.golaszewski@...aro.org>; Andrew Halaney
> >> <ahalaney@...hat.com>; Jisheng Zhang <jszhang@...nel.org>; Uwe
> >> Kleine-König <u.kleine-koenig@...gutronix.de>; Russell King
> >> <rmk+kernel@...linux.org.uk>
> >> Cc: Leyfoon Tan <leyfoon.tan@...rfivetech.com>; JeeHeng Sia
> >> <jeeheng.sia@...rfivetech.com>; netdev@...r.kernel.org;
> >> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> >> linux-stm32@...md-mailman.stormreply.com;
> >> linux-arm-kernel@...ts.infradead.org
> >> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac
> >> support
> >>
> >> On 08/01/2024 08:58, Tan Chun Hau wrote:
> >>> Add JH8100 dwmac support.
> >>>
> >>> Signed-off-by: Tan Chun Hau <chunhau.tan@...rfivetech.com>
> >>> ---
> >>>  drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >> b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> index 5d630affb4d1..373714f6e382 100644
> >>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct
> >> platform_device *pdev)
> >>>
> >>>  static const struct of_device_id starfive_dwmac_match[] = {
> >>>  	{ .compatible = "starfive,jh7110-dwmac"	},
> >>> +	{ .compatible = "starfive,jh8100-dwmac"	},
> >>
> >> No differences? Then why aren't the devices made compatible with each
> >> other?
> > There is a difference between JH7110 & JH8110,
> > JH7110 has two reset signals (ahb, stmmaceth), while JH8110 has only
> > one reset signal (stmmaceth), this will be shown in device tree file.
> 
> So if you are so picky then again: No differences in the driver? Then use
> compatibility or provide real arguments. NAK.
There are no differences in the driver.
Okay, the driver will remain the same, I will drop this change in V2. 
Thank you for the feedback.
> 
> Best regards,
> Krzysztof