netdev - RE: [PATCH] wangxunx: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02d101da42d7$471ee5a0$d55cb0e0$@trustnetic.com>
Date: Tue, 9 Jan 2024 16:38:53 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Arnd Bergmann'" <arnd@...nel.org>,
	"'Mengyuan Lou'" <mengyuanlou@...-swift.com>,
	"'Jakub Kicinski'" <kuba@...nel.org>
Cc: "'Arnd Bergmann'" <arnd@...db.de>,
	"'David S. Miller'" <davem@...emloft.net>,
	"'Eric Dumazet'" <edumazet@...gle.com>,
	"'Paolo Abeni'" <pabeni@...hat.com>,
	"'Russell King'" <linux@...linux.org.uk>,
	"'Andrew Lunn'" <andrew@...n.ch>,
	"'Maciej Fijalkowski'" <maciej.fijalkowski@...el.com>,
	"'Andy Shevchenko'" <andriy.shevchenko@...ux.intel.com>,
	"'Russell King \(Oracle\)'" <rmk+kernel@...linux.org.uk>,
	<netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] wangxunx: select CONFIG_PHYLINK where needed

> -----Original Message-----
> From: Arnd Bergmann <arnd@...nel.org>
> Sent: Tuesday, January 9, 2024 3:56 PM
> To: Jiawen Wu <jiawenwu@...stnetic.com>; Mengyuan Lou <mengyuanlou@...-swift.com>; Jakub Kicinski <kuba@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Paolo
> Abeni <pabeni@...hat.com>; Russell King <linux@...linux.org.uk>; Andrew Lunn <andrew@...n.ch>; Maciej Fijalkowski
> <maciej.fijalkowski@...el.com>; Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; Russell King (Oracle)
> <rmk+kernel@...linux.org.uk>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The ngbe driver needs phylink:
> 
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
> wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset'
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove':
> ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy'
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open':
> ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy'
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init':
> ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create'
> 
> Add the missing Kconfig description for this.
> 
> Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ethernet/wangxun/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> index 23cd610bd376..46630f05d8dd 100644
> --- a/drivers/net/ethernet/wangxun/Kconfig
> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -26,6 +26,7 @@ config NGBE
>  	tristate "Wangxun(R) GbE PCI Express adapters support"
>  	depends on PCI
>  	select LIBWX
> +	select PHYLINK
>  	select PHYLIB
>  	help
>  	  This driver supports Wangxun(R) GbE PCI Express family of
> --
> 2.39.2

Reviewed-by: Jiawen Wu <jiawenwu@...stnetic.com>