netdev - Ethernet binding: broken validation parsing of #nvmem-cell-cells ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdf7751b-0421-485d-8382-26c084f09d7d@gmail.com>
Date: Tue, 9 Jan 2024 11:03:26 +0100
From: Rafał Miłecki <zajec5@...il.com>
To: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Network Development <netdev@...r.kernel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Rob Herring
 <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <f.fainelli@...il.com>,
 linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Ethernet binding: broken validation parsing of #nvmem-cell-cells ?

Hi,

I'm playing with "dtbs_check" and I stuck on following errors:

arch/arm/boot/dts/broadcom/bcm47094-luxul-xwr-3150-v1.dtb: ethernet@...00: nvmem-cells: [[9], [0]] is too long
         from schema $id: http://devicetree.org/schemas/net/ethernet-controller.yaml#
arch/arm/boot/dts/broadcom/bcm47094-luxul-xwr-3150-v1.dtb: ethernet-switch@...07000: ports:port@4:nvmem-cells: [[9], [5]] is too long
         from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#

Context:

nvram@...f0000 {
	compatible = "brcm,nvram";
	reg = <0x1eff0000 0x10000>;

	et0macaddr: et0macaddr {
		#nvmem-cell-cells = <1>;
	};
};

&gmac0 {
	nvmem-cells = <&et0macaddr 0>;
	nvmem-cell-names = "mac-address";
};

The validation error comes from ethernet-controller.yaml which contains:

nvmem-cells:
   maxItems: 1
   description:
     Reference to an nvmem node for the MAC address

If I'm not mistaken <&et0macaddr 0> gets treated as two items.

Can someone tell me what's going on here and help me with solving it,
please? I would expect it to be sth trivial but I can't see any obvious
mistake.

-- 
Rafał Miłecki