netdev - Re: [PATCH net] net: dsa: fix netdev_priv() dereference before check on non-DSA netdevice events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK20iBqPvMv6xrjPK4ybVKx9VKAUXZJQJHVzLxVFg+RAA@mail.gmail.com>
Date: Wed, 10 Jan 2024 14:19:27 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, 
	Florian Fainelli <f.fainelli@...il.com>, Dan Carpenter <dan.carpenter@...cle.com>, 
	syzbot+d81bcd883824180500c8@...kaller.appspotmail.com
Subject: Re: [PATCH net] net: dsa: fix netdev_priv() dereference before check
 on non-DSA netdevice events

On Wed, Jan 10, 2024 at 1:34 AM Vladimir Oltean <vladimir.oltean@....com> wrote:
>
> After the blamed commit, we started doing this dereference for every
> NETDEV_CHANGEUPPER and NETDEV_PRECHANGEUPPER event in the system.
>
> static inline struct dsa_port *dsa_user_to_port(const struct net_device *dev)
> {
>         struct dsa_user_priv *p = netdev_priv(dev);
>
>         return p->dp;
> }

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks for the fix !