netdev - Re: [PATCH] tg3: add new module param to force device power down on reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLikZoXq17tp_152Oi4eYPd8BQLAv+LTxDgb4sHxX+8XiSA@mail.gmail.com>
Date: Wed, 10 Jan 2024 09:01:28 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Pavan Chebbi <pavan.chebbi@...adcom.com>, Andrea Fois <andrea.fois@...ntsense.it>, 
	Michael Chan <mchan@...adcom.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	George Shuklin <george.shuklin@...il.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tg3: add new module param to force device power down on reboot

On Tue, Jan 9, 2024 at 11:34 PM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 10.01.2024 08:17, Michael Chan wrote:
> > We already call dev_close() which will call tg3_close() -> tg3_stop()
> > a few lines above.
>
> tg3_stop() calls tg3_disable_ints(), so I wonder how a MSI interrupt can
> occur after that. Does tg3_disable_ints() disable interrupts synchronously?
> Or maybe some kind of commit is needed?
>

Yes, it is synchronous.  The tg3_full_lock() call before
tg3_disable_ints() makes it synchronous.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)