[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1784441.1704907412@warthog.procyon.org.uk>
Date: Wed, 10 Jan 2024 17:23:32 +0000
From: David Howells <dhowells@...hat.com>
To: Pengfei Xu <pengfei.xu@...el.com>
Cc: dhowells@...hat.com, eadavis@...com,
Linus Torvalds <torvalds@...ux-foundation.org>,
"Simon
Horman" <horms@...nel.org>,
Markus Suvanto <markus.suvanto@...il.com>,
"Jeffrey E Altman" <jaltman@...istor.com>,
Marc Dionne <marc.dionne@...istor.com>,
"Wang Lei" <wang840925@...il.com>, Jeff Layton <jlayton@...hat.com>,
Steve French <smfrench@...il.com>,
Jarkko Sakkinen <jarkko@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-afs@...ts.infradead.org,
keyrings@...r.kernel.org, linux-cifs@...r.kernel.org,
linux-nfs@...r.kernel.org, ceph-devel@...r.kernel.org,
netdev@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, heng.su@...el.com
Subject: Re: [PATCH] keys, dns: Fix missing size check of V1 server-list header
Meh. Does the attached fix it for you?
David
---
diff --git a/net/dns_resolver/dns_key.c b/net/dns_resolver/dns_key.c
index f18ca02aa95a..c42ddd85ff1f 100644
--- a/net/dns_resolver/dns_key.c
+++ b/net/dns_resolver/dns_key.c
@@ -104,7 +104,7 @@ dns_resolver_preparse(struct key_preparsed_payload *prep)
const struct dns_server_list_v1_header *v1;
/* It may be a server list. */
- if (datalen <= sizeof(*v1))
+ if (datalen < sizeof(*v1))
return -EINVAL;
v1 = (const struct dns_server_list_v1_header *)data;
Powered by blists - more mailing lists