netdev - Re: [PATCH bpf-next v2 15/15] selftests/bpf: states pruning checks for scalar vs STACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <458ecf3d755ffd7df33913b87cd6ad6f8e1c07ef.camel@gmail.com>
Date: Wed, 10 Jan 2024 22:27:13 +0200
From: Eduard Zingerman <eddyz87@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>, Maxim Mikityanskiy
	 <maxtram95@...il.com>
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>,  Andrii Nakryiko <andrii@...nel.org>, Shung-Hsi Yu
 <shung-hsi.yu@...e.com>, John Fastabend <john.fastabend@...il.com>,  Martin
 KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song
 <yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>, Stanislav
 Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,  Jiri Olsa
 <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>, Shuah Khan
 <shuah@...nel.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org, 
 netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 15/15] selftests/bpf: states pruning checks
 for scalar vs STACK_{MISC,ZERO}

On Tue, 2024-01-09 at 16:27 -0800, Andrii Nakryiko wrote:
[...]
> same, please double check this STACK_xxx assumptions, as now we spill
> registers instead of STACK_ZERO in a lot of cases

Right, the test is outdated after your recent fixes for STACK_ZERO.
Thank you for catching this.