netdev - Re: [PATCH] wangxunx: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5a08d4a0-a6d6-4c9a-8bdf-1ccb4f200d26@app.fastmail.com>
Date: Thu, 11 Jan 2024 17:29:02 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Russell King" <linux@...linux.org.uk>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Jiawen Wu" <jiawenwu@...stnetic.com>,
 "Mengyuan Lou" <mengyuanlou@...-swift.com>,
 "Jakub Kicinski" <kuba@...nel.org>, "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>,
 "Andrew Lunn" <andrew@...n.ch>,
 "Maciej Fijalkowski" <maciej.fijalkowski@...el.com>,
 "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed

On Thu, Jan 11, 2024, at 16:49, Russell King (Oracle) wrote:
> On Tue, Jan 09, 2024 at 09:35:50AM +0000, Russell King (Oracle) wrote:
>> On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote:
>> > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
>> > index 23cd610bd376..46630f05d8dd 100644
>> > --- a/drivers/net/ethernet/wangxun/Kconfig
>> > +++ b/drivers/net/ethernet/wangxun/Kconfig
>> > @@ -26,6 +26,7 @@ config NGBE
>> >  	tristate "Wangxun(R) GbE PCI Express adapters support"
>> >  	depends on PCI
>> >  	select LIBWX
>> > +	select PHYLINK
>> >  	select PHYLIB
>> 
>> You can drop PHYLIB when adding PHYLINK.
>
> Arnd,
>
> There are repeated complaints from the kernel build bot about this, and
> it would be good to get it solved. Could we have an updated patch
> submitted to netdev please? This is in net-next only at the moment,
> so I think that means it needs to be submitted with:
>
> 	[PATCH net-next ...]
>
> and please make it clear that it is a fix for code only in net-next.
> (However, netdev folk may request it to be referred until net-next is
> merged and then against the net tree...)

Sent now, thanks for the reminder.

     Arnd