netdev - Re: [PATCH net] net: micrel: Fix PTP frame parsing for lan8841

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzofy8aq.fsf@nvidia.com>
Date: Thu, 11 Jan 2024 11:31:58 -0800
From: Rahul Rameshbabu <rrameshbabu@...dia.com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, richardcochran@...il.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net] net: micrel: Fix PTP frame parsing for lan8841

On Wed, 10 Jan, 2024 12:37:30 +0100 Horatiu Vultur <horatiu.vultur@...rochip.com> wrote:
> The HW has the capability to check each frame if it is a PTP frame,
> which domain it is, which ptp frame type it is, different ip address in
> the frame. And if one of these checks fail then the frame is not
> timestamp. Most of these checks were disabled except checking the field
> minorVersionPTP inside the PTP header. Meaning that once a partner sends
> a frame compliant to 8021AS which has minorVersionPTP set to 1, then the
> frame was not timestamp because the HW expected by default a value of 0
> in minorVersionPTP.
> Fix this issue by removing this check so the userspace can decide on this.
>
> Fixes: cafc3662ee3f ("net: micrel: Add PHC support for lan8841")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---

This is a good design decision.

Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>