netdev - Re: [PATCH net] amt: do not use overwrapped cb area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25bcf5e2ddb3eb2de2c97f72296e605c2e27b2eb.camel@redhat.com>
Date: Thu, 11 Jan 2024 11:50:23 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Taehee Yoo <ap420073@...il.com>, davem@...emloft.net, kuba@...nel.org, 
	edumazet@...gle.com, netdev@...r.kernel.org
Cc: paulb@...dia.com, jhs@...atatu.com
Subject: Re: [PATCH net] amt: do not use overwrapped cb area

On Sun, 2024-01-07 at 14:42 +0000, Taehee Yoo wrote:
> amt driver uses skb->cb for storing tunnel information.
> This job is worked before TC layer and then amt driver load tunnel info
> from skb->cb after TC layer.
> So, its cb area should not be overwrapped with CB area used by TC.
> In order to not use cb area used by TC, it skips the biggest cb
> structure used by TC, which was qdisc_skb_cb.
> But it's not anymore.
> Currently, biggest structure of TC's CB is tc_skb_cb.
> So, it should skip size of tc_skb_cb instead of qdisc_skb_cb.
> 
> Fixes: ec624fe740b4 ("net/sched: Extend qdisc control block with tc control block")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

The patch LGTM, but I can't merge it ATM, as even the net tree is
currently frozen until the net-next PR is merged back. Let me leave my
tag explicitly to hopefully save some time for Jakub and/or Dave.

Acked-by: Paolo Abeni <pabeni@...hat.com>

Cheers,

Paolo