netdev - Re: [PATCH v4] net: stmmac: Prevent DSA tags from breaking COE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99289be4aa940932acbf728ba6a926c67eb5484a.camel@redhat.com>
Date: Thu, 11 Jan 2024 12:49:47 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Romain Gantois <romain.gantois@...tlin.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>, Miquel Raynal
 <miquel.raynal@...tlin.com>, Maxime Chevallier
 <maxime.chevallier@...tlin.com>,  Sylvain Girard <sylvain.girard@...com>,
 Pascal EBERHARD <pascal.eberhard@...com>, Richard Tresidder
 <rtresidd@...ctromag.com.au>, Linus Walleij <linus.walleij@...aro.org>, 
 Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>,  netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com, 
 linux-arm-kernel@...ts.infradead.org, stable@...r.kernel.org, Vladimir
 Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH v4] net: stmmac: Prevent DSA tags from breaking COE

On Tue, 2024-01-09 at 15:42 +0100, Romain Gantois wrote:
> Some DSA tagging protocols change the EtherType field in the MAC header
> e.g.  DSA_TAG_PROTO_(DSA/EDSA/BRCM/MTK/RTL4C_A/SJA1105). On TX these tagged
> frames are ignored by the checksum offload engine and IP header checker of
> some stmmac cores.
> 
> On RX, the stmmac driver wrongly assumes that checksums have been computed
> for these tagged packets, and sets CHECKSUM_UNNECESSARY.
> 
> Add an additional check in the stmmac TX and RX hotpaths so that COE is
> deactivated for packets with ethertypes that will not trigger the COE and
> IP header checks.
> 
> Fixes: 6b2c6e4a938f ("net: stmmac: propagate feature flags to vlan")
> Cc:  <stable@...r.kernel.org>
> Reported-by: Richard Tresidder <rtresidd@...ctromag.com.au>
> Link: https://lore.kernel.org/netdev/e5c6c75f-2dfa-4e50-a1fb-6bf4cdb617c2@electromag.com.au/
> Reported-by: Romain Gantois <romain.gantois@...tlin.com>
> Link: https://lore.kernel.org/netdev/c57283ed-6b9b-b0e6-ee12-5655c1c54495@bootlin.com/
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Romain Gantois <romain.gantois@...tlin.com>

Unfortunately, you dropped the target tree tag ('net') from the
subject, and did not allow our CI to trigger properly.

Since we can't merge this patch ATM ('net' is currently frozen since we
merge back the net-next PR), I think it's better if you resubmit with a
proper tag. You can retain all Vladimir Rb tag.

Cheers,

Paolo