netdev - Re: [PATCH iproute2] man/tc-mirred: don't recommend modprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZaGDLociGHMaumZY@nanopsycho>
Date: Fri, 12 Jan 2024 19:21:34 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] man/tc-mirred: don't recommend modprobe

Fri, Jan 12, 2024 at 06:09:15PM CET, stephen@...workplumber.org wrote:
>On Fri, 12 Jan 2024 13:44:47 +0100
>Jiri Pirko <jiri@...nulli.us> wrote:
>
>> Thu, Jan 11, 2024 at 08:34:44PM CET, stephen@...workplumber.org wrote:
>> >Use ip link add instead of explicit modprobe.
>> >Kernel will do correct module loading if necessary.
>> >
>> >Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>> >---
>> > man/man8/tc-mirred.8 | 3 +--
>> > 1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> >diff --git a/man/man8/tc-mirred.8 b/man/man8/tc-mirred.8
>> >index 38833b452d92..2d9795b1b16f 100644
>> >--- a/man/man8/tc-mirred.8
>> >+++ b/man/man8/tc-mirred.8
>> >@@ -84,8 +84,7 @@ interface, it is possible to send ingress traffic through an instance of
>> > 
>> > .RS
>> > .EX
>> >-# modprobe ifb
>> >-# ip link set ifb0 up
>> >+# ip link add dev ifb0 type ifb  
>> 
>> RTNETLINK answers: File exists
>> 
>> You can't add "ifb0" like this, it is created implicitly on module probe
>> time. Pick a different name.
>
>Right.
>Looks like ifb is behaving differently than other devices.
>For example, doing modprobe of dummy creates no device.

Older drivers did do this. Bonding modprobe also created bond0 in
the past. Now it does not. I guess ifb behaviour could be changed as
well.

>
>