netdev - Re: [PATCH net 5/5] mptcp: refine opt_mp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240112193724.GG392144@kernel.org>
Date: Fri, 12 Jan 2024 19:37:24 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Matthieu Baerts <matttbe@...nel.org>,
	Mat Martineau <martineau@...nel.org>,
	Geliang Tang <geliang.tang@...ux.dev>,
	Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH net 5/5] mptcp: refine opt_mp_capable determination

On Thu, Jan 11, 2024 at 07:49:17PM +0000, Eric Dumazet wrote:
> OPTIONS_MPTCP_MPC is a combination of three flags.
> 
> It would be better to be strict about testing what
> flag is expected, at least for code readability.
> 
> mptcp_parse_option() already makes the distinction.
> 
> - subflow_check_req() should use OPTION_MPTCP_MPC_SYN.
> 
> - mptcp_subflow_init_cookie_req() should use OPTION_MPTCP_MPC_ACK.
> 
> - subflow_finish_connect() should use OPTION_MPTCP_MPC_SYNACK
> 
> - subflow_syn_recv_sock should use OPTION_MPTCP_MPC_ACK
> 
> Suggested-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>