netdev - Re: [PATCH net 2/2] net: tls, add test to capture error on large splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65a1b4aabc0ff_4054208c2@john.notmuch>
Date: Fri, 12 Jan 2024 13:52:42 -0800
From: John Fastabend <john.fastabend@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 John Fastabend <john.fastabend@...il.com>
Cc: netdev@...r.kernel.org, 
 eadavis@...com, 
 bpf@...r.kernel.org, 
 borisp@...dia.com
Subject: Re: [PATCH net 2/2] net: tls, add test to capture error on large
 splice

Jakub Kicinski wrote:
> On Wed, 10 Jan 2024 14:01:24 -0800 John Fastabend wrote:
> > +		EXPECT_EQ(splice(p[0], NULL, self->fd, NULL, send_pipe, 0xe), 1);
> 
> Any reason to use 0xe rather than the SPLICE_F_* defines for flags?

No reason I crafted the test first and then forgot to come back
and tidy it much.

I'll send a v2 with readable names.