netdev - Re: [PATCH net-next v3 3/8] net: dsa: realtek: common realtek-dsa module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240115215045.gnm364kfsw3jbgoe@skbuf>
Date: Mon, 15 Jan 2024 23:50:45 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: netdev@...r.kernel.org, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
	andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	arinc.unal@...nc9.com
Subject: Re: [PATCH net-next v3 3/8] net: dsa: realtek: common realtek-dsa
 module

On Sat, Jan 13, 2024 at 06:38:39PM -0300, Luiz Angelo Daros de Luca wrote:
> I didn't like realtek_probe() either. It is too generic, although now
> in a specific name space.
> How about replacing all realtek_common with rtl83xx? I guess all
> rtl83xx chips are switch controllers, even though some of them have an
> embedded mips core.
> Or we could include a prefix/suffix as well like rtl83xx_dsa or realtek_dsa..

I don't have a problem with just rtl83xx.