netdev - Re: [PATCH] connector: Change the judgment conditions for clearing proc_event_num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240115155939.5d206775@kernel.org>
Date: Mon, 15 Jan 2024 15:59:39 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: wangkeqi  <wangkeqi_chris@....com>
Cc: "Yin, Fengwei" <fengwei.yin@...el.com>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, wangkeqi <wangkeqiwang@...iglobal.com>
Subject: Re: [PATCH] connector: Change the judgment conditions for clearing
 proc_event_num_listeners

On Mon, 15 Jan 2024 17:26:39 +0800 (CST) wangkeqi wrote:
> From: wangkeqi <wangkeqiwang@...iglobal.com>
> 
> It is inaccurate to judge whether proc_event_num_listeners is
> cleared by cn_netlink_send_mult returning -ESRCH.
> In the case of stress-ng netlink-proc, -ESRCH will always be returned,
> because netlink_broadcast_filtered will return -ESRCH,
> which may cause stress-ng netlink-proc performance degradation.
> Therefore, the judgment condition is modified to whether
> there is a listener.
> 
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202401112259.b23a1567-oliver.sang@intel.com
> Signed-off-by: wangkeqi <wangkeqiwang@...iglobal.com>
> Cc: fengwei.yin@...el.com

Please stop posting the patches as a reply to the previous submission
with a quote at the end.. Post the new version generated by git with
--subject-prefix="PATCH net v2" and send it with git send-email as 
a new thread.

Please add an appropriate Fixes tag.
-- 
pw-bot: cr