netdev - Re: [PATCH bpf-next v2 0/6] Zbb support and code simplification for RV64 JIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <421fcfcd-6be6-4dfc-9948-3b57c7517538@huaweicloud.com>
Date: Mon, 15 Jan 2024 20:22:51 +0800
From: Pu Lehui <pulehui@...weicloud.com>
To: Björn Töpel <bjorn@...nel.org>, bpf@...r.kernel.org,
 linux-riscv@...ts.infradead.org, netdev@...r.kernel.org
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Palmer Dabbelt <palmer@...belt.com>, Conor Dooley <conor@...nel.org>,
 Luke Nelson <luke.r.nels@...il.com>, Pu Lehui <pulehui@...wei.com>
Subject: Re: [PATCH bpf-next v2 0/6] Zbb support and code simplification for
 RV64 JIT



On 2023/9/28 18:44, Björn Töpel wrote:
> Pu Lehui <pulehui@...weicloud.com> writes:
> 
>> Add Zbb support [0] to optimize code size and performance of RV64 JIT.
>> Meanwhile, adjust the code for unification and simplification. Tests
>> test_bpf.ko and test_verifier have passed, as well as the relative
>> testcases of test_progs*.
> 
> Nice work!
> 
> Did you measure how the instruction count changed for, say, test_bpf.ko
> and test_progs? >

Sorry for not responding for so long.

I made statistics on the number of body instructions and the changes are 
as follows:

test_progs:
1. verifier_movsx: 260 -> 224
2. verifier_bswap: 180 -> 56

test_bpf.ko:
1. MOVSX: 154 -> 146
2. BSWAP: 336 -> 136

We can see that the change in BSWAP is obvious, and the change in MOVSX 
is in line with expectations.

> 
> Björn