netdev - Re: [PATCH net] selftests: bonding: add missing build configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 09:37:40 -0500
From: Benjamin Poirier <bpoirier@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, j.vosburgh@...il.com, andy@...yhouse.net,
	shuah@...nel.org, jon.toppins+linux@...il.com,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: bonding: add missing build configs

On 2024-01-15 18:02 -0800, Jakub Kicinski wrote:
> bonding tests also try to create bridge, veth and dummy
> interfaces. These are not currently listed in config.
> 
> Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management")
> Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: j.vosburgh@...il.com
> CC: andy@...yhouse.net
> CC: shuah@...nel.org
> CC: bpoirier@...dia.com
> CC: jon.toppins+linux@...il.com
> CC: linux-kselftest@...r.kernel.org
> ---
>  tools/testing/selftests/drivers/net/bonding/config | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config
> index 70638fa50b2c..f85b16fc5128 100644
> --- a/tools/testing/selftests/drivers/net/bonding/config
> +++ b/tools/testing/selftests/drivers/net/bonding/config
> @@ -1,2 +1,5 @@
>  CONFIG_BONDING=y
> +CONFIG_BRIDGE=y
> +CONFIG_DUMMY=y
>  CONFIG_MACVLAN=y
> +CONFIG_VETH=y
> -- 

Hi,

I tested using the minimal config generated by virtme-ng and the
following additional config options need to be enabled for bonding
tests:
CONFIG_IPV6=y
CONFIG_NET_ACT_GACT=y
CONFIG_NET_CLS_FLOWER=y
CONFIG_NET_SCH_INGRESS=y
CONFIG_NLMON=y