netdev - Re: [PATCH net] selftests: bonding: Add more missing config options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZabdYhBRHiNt-jGy@d3>
Date: Tue, 16 Jan 2024 14:47:46 -0500
From: Benjamin Poirier <bpoirier@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jay Vosburgh <jay.vosburgh@...onical.com>,
	Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org,
	Andy Gospodarek <andy@...yhouse.net>, Shuah Khan <shuah@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jonathan Toppins <jon.toppins+linux@...il.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Michal Kubiak <michal.kubiak@...el.com>,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: bonding: Add more missing config options

On 2024-01-16 11:29 -0800, Jakub Kicinski wrote:
> On Tue, 16 Jan 2024 14:21:51 -0500 Benjamin Poirier wrote:
> > real    13m35.065s
> > user    0m1.657s
> > sys     0m27.918s
> > 
> > The test is not cpu bound; as Jay pointed out, it spends most of its
> > time sleeping.
> 
> Ugh, so it does multiple iterations of 118 sec?

There are other test functions in the script which include a lot of
sleeping.

> Could you send a patch to bump the timeout to 900 or 1200 in this case?

Sure but I'd like to give a chance for Hangbin to reply first. Would the
test be just as good if it was shortened by removing some cases or
reducing the time intervals? Or is increasing the timeout the best
approach?